[Okular-devel] Review Request: Allow PDF Generator to handle embedded movies

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104292/#review11726
-----------------------------------------------------------



core/movie.cpp
<http://git.reviewboard.kde.org/r/104292/#comment9309>

    qDebug -> kDebug
    
    And there should be a way to notify the user that something went wrong (no disk space?). Probably when clicking on the link, not when creating the tmp file.



ui/pageview.cpp
<http://git.reviewboard.kde.org/r/104292/#comment9310>

    This change has been applied already


- Albert Astals Cid


On March 21, 2012, 10:56 p.m., Guillermo Antonio Amaral Bastidas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104292/
> -----------------------------------------------------------
> 
> (Updated March 21, 2012, 10:56 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> Handles new Screen annotations in Poppler and displays using a Movie annotation.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindPoppler.cmake 6b1ad66 
>   core/movie.h f4b64e1 
>   core/movie.cpp 8c7ffa5 
>   generators/poppler/annots.cpp 2944b64 
>   generators/poppler/config-okular-poppler.h.cmake 3f88d7f 
>   generators/poppler/generator_pdf.cpp 391d304 
>   ui/pageview.cpp 573d3e9 
> 
> Diff: http://git.reviewboard.kde.org/r/104292/diff/
> 
> 
> Testing
> -------
> 
> Tested on Linux (VLC and GStreamer phonon backends)
> 
> 
> Thanks,
> 
> Guillermo Antonio Amaral Bastidas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120321/10a7a488/attachment-0001.html>