[Okular-devel] Review Request: Allow PDF Generator to handle embedded movies

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104292/#review11453
-----------------------------------------------------------


Can we have a file you've tested the stuff with?


generators/poppler/annots.cpp
<http://git.reviewboard.kde.org/r/104292/#comment9129>

    This needs an #ifdef check, have a look at cmake/modules/FindPoppler.cmake and create one named POPPLER_0_20 that checks what you need



generators/poppler/generator_pdf.cpp
<http://git.reviewboard.kde.org/r/104292/#comment9130>

    same here for ifdedf



generators/poppler/generator_pdf.cpp
<http://git.reviewboard.kde.org/r/104292/#comment9131>

    and here


- Albert Astals Cid


On March 15, 2012, 8:21 p.m., Guillermo Antonio Amaral Bastidas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104292/
> -----------------------------------------------------------
> 
> (Updated March 15, 2012, 8:21 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> Handles new Screen annotations in Poppler and displays using a Movie annotation.
> 
> 
> Diffs
> -----
> 
>   core/movie.h f4b64e1 
>   core/movie.cpp 8c7ffa5 
>   generators/poppler/annots.cpp 2944b64 
>   generators/poppler/generator_pdf.cpp 391d304 
> 
> Diff: http://git.reviewboard.kde.org/r/104292/diff/
> 
> 
> Testing
> -------
> 
> Tested on Linux (VLC and GStreamer phonon backends)
> 
> 
> Thanks,
> 
> Guillermo Antonio Amaral Bastidas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120315/b91c147b/attachment-0001.html>