[Okular-devel] Bug 157198 - Remember position on the page in bookmark

[Mailson Lira]

Hi everyone,

Currently I'm working on this new
feature[1<https://bugs.kde.org/show_bug.cgi?id=157198>]
which is make bookmark remember where in the page it was saved. The
solution is to make the bookmark save the center of the viewport, not only
the page number. With that in mind, the user now can have as many bookmarks
as he wants on a given page.

This will change the behavior of the program, so I need to ask a few
questions on how this should work.

== Case 1 - "Remove bookmark" menu action ==

If you right click on a *bookmarked* page (or click on Bookmark in
menubar), you'll see an option to remove the current bookmark instead of
adding a new one.

Since the user can add another bookmark on another position we can't simply
show the "Remove bookmark" option on a bookmarked page anymore.

So what should we do with the "Remove bookmark" option?
- Check if the use is at the exact position of the bookmark and then show
the option to remove it? That may not be a good idea since if the user
moves 1px to the left, he's not on that bookmark position anymore.

- Show an extra option to remove all bookmarks on the page or the last
bookmark added? With that the "Remove bookmark" will not replace the "Add
bookmark" option.

- Make the "Remove bookmark" option available when the viewport very close
to the bookmark position, so it doesn't need to be at the exact position.
That's tricky.

Any suggestions?

== Case 2 - Ctrl+B shortcut ==

The Ctrl+B shortcut add or remove the page to bookmark. That may not work
well if we have many bookmarks in the page.
Should we detect if the current viewport is saved to bookmarks and then
Ctrl+B will remove them? Or that shortcut will just add bookmark and the
user needs to go to the list of saved bookmarks on the left side and remove
it manually?

The first can lead to undesirable results such as the user adding various
bookmarks on very close (but different) positions when what he really
wanted was to remove a bookmark.

== Case 3 - Save only one bookmark per page ==

The bookmark will remember the position on the page but will still allow
only one bookmark per page. That will not change the behavior of okular but
IMHO doesn't make much sense.

== ==

Sorry for the long message but I had to ask those questions.

[1] https://bugs.kde.org/show_bug.cgi?id=157198

--
Mailson Lira
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120312/6797cee6/attachment.html>