[Okular-devel] Review Request: Improve activation of video playback in Okular

[Tobias Koenig]

> On March 8, 2012, 7:17 p.m., Albert Astals Cid wrote:
> > What's the rationale of the setActive bit? Can we just shown/hide the videowidget?

I wasn't sure if there are other calls to show()/hide() that might interfere with it, therefor I decoupled it. I can recheck the code and change everything to show()/hide() if you prefer.


- Tobias


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104159/#review11242
-----------------------------------------------------------


On March 7, 2012, 3:07 p.m., Tobias Koenig wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104159/
> -----------------------------------------------------------
> 
> (Updated March 7, 2012, 3:07 p.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Description
> -------
> 
> The patch improves the activation of video playback by hiding the VideoWidget until the user has clicked the area where the video is located. This will ensure that a 'first frame' image is visible and won't be covered by a black Phonon::VideoPlayer widget.
> Additionally it adds some checks to change the mouse pointer to a different cursor when the video area is entered and it disables the 'edit annotation' dialog for MovieAnnotations.
> 
> 
> Diffs
> -----
> 
>   ui/pageview.cpp 344a944 
>   ui/presentationwidget.h e90d21b 
>   ui/presentationwidget.cpp bbeb9f5 
>   ui/videowidget.h b3ca14e 
>   ui/videowidget.cpp 2a48772 
> 
> Diff: http://git.reviewboard.kde.org/r/104159/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tobias Koenig
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120310/6d30882d/attachment.html>