[Okular-devel] [Feature][Patch] Renaming top-level bookmarks

[Albert Astals Cid]

El Dijous, 8 de març de 2012, a les 18:06:07, Costash va escriure:
> Hi,

Hi

> 
> I have finally made this to work as it should.
> 
> Brief description of what I did:
> 
> I created a menu entry in contextMenuForFileItem to be able to edit the
> top-level bookmarks (fileItems).
> I made a function in BookmarkManager class to be able to rename a bookmark
> referenced by its KUrl, and used it
> 
> in slotChanged. The greatest challenge was to get the *title* for the
> current item, and this is why I overloaded the
> currentTitle function.
> 
> I am waiting for any feedback and I hope this patch can be pushed upstream.

I've cleaned it up a bit (mostly you were removing the overload of 
KBookmarkOwner::currentTile(), that even if we don't really use, was bad).

Good work :-)

Albert

> 
> Yours sincerely,
> Constantin Serban-Radoi.