[Okular-devel] Review Request: Add greedy preloading option

[Sebastian Rose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103129/
-----------------------------------------------------------

(Updated March 8, 2012, 10:23 a.m.)


Review request for Okular.


Changes
-------

It's been a while but I did the suggested changes since it's more consistent with the description. Set the maximum limit of pages to allocate to the numeric limit of a signed int. Also, removed unloading completely.


Description
-------

After discovering that the aggressive behaviour in okular is not that aggressive at all (preloads only the next 2 pages) I've written the attached patch to add a "Greedy" option. It preloads every page into memory.


Diffs (updated)
-----

  conf/dlgperformance.cpp fd0e30b 
  conf/dlgperformancebase.ui b022f56 
  conf/okular.kcfg b1373b3 
  core/document.cpp 74757f1 
  ui/pageview.cpp 28835ed 
  ui/presentationwidget.cpp bbeb9f5 

Diff: http://git.reviewboard.kde.org/r/103129/diff/


Testing
-------

Tested it on my local system, I'm using the modified okular with the new greedy option checked and don't have any issues so far. The memory requirement for a 580 page (color) PDF file is about 1 GiB, the bulk of it for the pixmaps. Other (e.g. unloading) behaviour is like "Aggressive". It takes a while for the whole document to be prerendered but after that it works as expected.


Thanks,

Sebastian Rose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120308/ceee384d/attachment.html>