[Okular-devel] Review Request: Improve activation of video playback in Okular

[Tobias Koenig]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104159/
-----------------------------------------------------------

(Updated March 7, 2012, 3:07 p.m.)


Review request for Okular and Albert Astals Cid.


Changes
-------

The new diff fixes the behaviour of VideoWidget::setActive(true) and omits the 'special' handling of movie annotations.


Description
-------

The patch improves the activation of video playback by hiding the VideoWidget until the user has clicked the area where the video is located. This will ensure that a 'first frame' image is visible and won't be covered by a black Phonon::VideoPlayer widget.
Additionally it adds some checks to change the mouse pointer to a different cursor when the video area is entered and it disables the 'edit annotation' dialog for MovieAnnotations.


Diffs (updated)
-----

  ui/pageview.cpp 344a944 
  ui/presentationwidget.h e90d21b 
  ui/presentationwidget.cpp bbeb9f5 
  ui/videowidget.h b3ca14e 
  ui/videowidget.cpp 2a48772 

Diff: http://git.reviewboard.kde.org/r/104159/diff/


Testing
-------


Thanks,

Tobias Koenig

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120307/f5bdb7ab/attachment.html>