[Okular-devel] Review Request: Improve activation of video playback in Okular

[Tobias Koenig]

> On March 5, 2012, 10:34 p.m., Albert Astals Cid wrote:
> > I don't think i like this much.
> >  * Who is painting that 'first frame' image? What if there is none?
> >  * It seems to me that show(); setActive(false); setActive(true); will result in stuff still not being shown, doesn't look right
> >  * MovieAnnotations are still annotations, why should we not let people change the contents like for the rest of annotations?

Hej Albert,

the 'first frame' image is a normal PDF image object that is placed at the same position where the movie annotation is located (this is done internally by the generating app like latex-beamer or ooimpress).
However the image and the movie annotation are not associated/referenced in some way (inside the PDF document), so we can't say "only if there is a first-frame image hide the video widget".
If there is no 'first frame' image, then the area will stay empty, that's consistent with the behaviour of Acroread, so this won't confuse users.

You are right about the show()/setActive(false)/setActive(true) sequence, will fix this.

I just thought that the movie annotation can not really be seen as an annotation because it cannot be changed by the user (unlike a text annotation where the text can be changed). But I won't fight about this one, if you think it should behave like a normal annotation, then I can omit this part of the patch.

Any other objections/suggestions?


- Tobias


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104159/#review11163
-----------------------------------------------------------


On March 5, 2012, 2:46 p.m., Tobias Koenig wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104159/
> -----------------------------------------------------------
> 
> (Updated March 5, 2012, 2:46 p.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Description
> -------
> 
> The patch improves the activation of video playback by hiding the VideoWidget until the user has clicked the area where the video is located. This will ensure that a 'first frame' image is visible and won't be covered by a black Phonon::VideoPlayer widget.
> Additionally it adds some checks to change the mouse pointer to a different cursor when the video area is entered and it disables the 'edit annotation' dialog for MovieAnnotations.
> 
> 
> Diffs
> -----
> 
>   ui/pageview.cpp 344a944 
>   ui/presentationwidget.h e90d21b 
>   ui/presentationwidget.cpp bbeb9f5 
>   ui/videowidget.h b3ca14e 
>   ui/videowidget.cpp 2a48772 
> 
> Diff: http://git.reviewboard.kde.org/r/104159/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tobias Koenig
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120307/803d60ce/attachment.html>