[Okular-devel] Review Request: Remember the mouse mode on exit

[Parker Coates]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104147/
-----------------------------------------------------------

(Updated March 6, 2012, 2:48 a.m.)


Review request for Okular.


Changes
-------

As Albert suggested, get rid of the local storage of the mouse mode and the local MouseMode enum.

Note that there used to be a MouseImageSelect enum value used in the code, which I have removed. I'm pretty sure this is fine as the image selection functionality seems to have been rolled into the normal selection.

I also changed the Normal enum to Browse, so that the config file better matches the UI.


Description
-------

The default mouse mode on Okular startup is panning. I almost always want text selection. Somebody else might prefer rectangular selection or zooming.

This patch stores the last active mouse mode in the config and switches to it on startup.


Diffs (updated)
-----

  conf/okular.kcfg b1373b3 
  ui/pageview.h df7ac33 
  ui/pageview.cpp 344a944 
  ui/toolaction.cpp 149391f 

Diff: http://git.reviewboard.kde.org/r/104147/diff/


Testing
-------

Tested closing and restarting Okular once for each of the 5 modes.


Thanks,

Parker Coates

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120306/8211e5d4/attachment.html>