[Okular-devel] Review Request: Remember the mouse mode on exit

Albert Astals Cid tsdgeos at terra.es
Mon Mar 5 22:02:27 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104147/#review11162
-----------------------------------------------------------


We don't need d->mouseMode nor the enums for it in the pageview anymore, just store the status in the settings class

- Albert Astals Cid


On March 3, 2012, 10:49 p.m., Parker Coates wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104147/
> -----------------------------------------------------------
> 
> (Updated March 3, 2012, 10:49 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> The default mouse mode on Okular startup is panning. I almost always want text selection. Somebody else might prefer rectangular selection or zooming.
> 
> This patch stores the last active mouse mode in the config and switches to it on startup.
> 
> 
> Diffs
> -----
> 
>   conf/okular.kcfg b1373b3 
>   ui/pageview.cpp 344a944 
>   ui/toolaction.cpp 149391f 
> 
> Diff: http://git.reviewboard.kde.org/r/104147/diff/
> 
> 
> Testing
> -------
> 
> Tested closing and restarting Okular once for each of the 5 modes.
> 
> 
> Thanks,
> 
> Parker Coates
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120305/e8bcd4e9/attachment.html>


More information about the Okular-devel mailing list