[Okular-devel] Review Request: Replace deprecated QMatrix by QTransform

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105737/#review16725
-----------------------------------------------------------


This changes public API (core/*.h) without any real reason so this is not going in, sorry. If you can you can provide a patch that marks the places of public api as // TODO change when doing an SIC change and that keeps the changes in non public code

- Albert Astals Cid


On July 26, 2012, 1:09 p.m., Jan Binder wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105737/
> -----------------------------------------------------------
> 
> (Updated July 26, 2012, 1:09 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> QMatrix is deprecated since Qt 4.6 according to Qt documentation.
> Luckily, QTransform acts as a more powerful drop-in replacement.
> This patch replaces all instances of QMatrix with QTransform and adds headers where necessary.
> 
> 
> Diffs
> -----
> 
>   core/annotations.h 23deaf3 
>   core/annotations.cpp bc55f4b 
>   core/annotations_p.h 36c3785 
>   core/area.h a11d4be 
>   core/area.cpp 94b4514 
>   core/page.cpp c778fe2 
>   core/page_p.h 02281f1 
>   core/rotationjob.cpp 625a5d2 
>   core/rotationjob_p.h 9790b64 
>   core/textpage.h a0b41c7 
>   core/textpage.cpp 57d0d0c 
>   core/textpage_p.h 7c2be22 
>   generators/spectre/rendererthread.cpp f185d22 
>   generators/xps/generator_xps.h b4fa594 
>   generators/xps/generator_xps.cpp 97f4450 
> 
> Diff: http://git.reviewboard.kde.org/r/105737/diff/
> 
> 
> Testing
> -------
> 
> Okular still compiles without errors related to QMatrix or QTransform, document rotation still works, XPS documents still seem to work.
> 
> 
> Thanks,
> 
> Jan Binder
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120731/8f8e4702/attachment.html>