[Okular-devel] [Bug 257370] "Trim Margins" cuts too much

[Fabio D'Urso]

https://bugs.kde.org/show_bug.cgi?id=257370

Fabio D'Urso <fabiodurso at hotmail.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|http://commits.kde.org/okul |http://commits.kde.org/okul
                   |ar/edbb4ef9f5aa8f120558b9d4 |ar/5b12bf685df1c02be025cdb8
                   |f4b9f68970100c4b            |70f97df62da72b09

--- Comment #9 from Fabio D'Urso <fabiodurso at hotmail.it> ---
Git commit 5b12bf685df1c02be025cdb870f97df62da72b09 by Fabio D'Urso.
Committed on 17/07/2012 at 20:35.
Pushed by fabiod into branch 'master'.

Call Generator::signalPixmapRequestDone _after_ saving the calculated bounding
box

Fixes a bug that causes the extraction of a wrong bounding box:

If the request queue is not empty, signalPixmapRequestDone causes a new
pixmap request to be started, thus overwriting mPixmapGenerationThread's
mCalcBoundingBox before it is read by the if in the next line.

Now signalPixmapRequestDone is called after the bounding box is saved,
so that new requests are started only after all data from
mPixmapGenerationThread have been saved.
REVIEW: 105600

M  +1    -1    core/generator.cpp

http://commits.kde.org/okular/5b12bf685df1c02be025cdb870f97df62da72b09

-- 
You are receiving this mail because:
You are the assignee for the bug.