[Okular-devel] Review Request: Allow the page number selector to be docked in a toolbar

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103427/#review10005
-----------------------------------------------------------


Hi, me again, sorry for the delay.

I find the current implementation a bit confusing user-wise since i can have the "Page number" toolbar shown and no "Page number" toolbar is really visible at all since the other page widget is visible.
For that i'm suggesting two solutions:
 a) Do not force the limit of only one minibar available, so the user can have none, one or two page widgets visible
 b) Uncheck the "Page number" toolbar action when the "old" page widget is visible, and then if somebody checks it, toggle it back

The option b) looks difficult-ish since you'd probably have to do quite a bit of xml-gui vodoo to make it work nicely, so i'm leaning towards a)

What do you think?

- Albert Astals Cid


On Dec. 28, 2011, 8:21 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103427/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2011, 8:21 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> The bug (and duplicates) suggests that the page bar which normally appears at the bottom of the Okular window could be docked in the toolbar, in order to save vertical screen space which is especially useful on a wide screen.  This patch implements that.
> 
> There can only be one MiniBar in existence, because of the fixed observer ID (which must be unique).  So the page tool only appears in the toolbar if the page bar is hidden;  if it is shown, then the page number and size label appears there as before.  The MiniBar is reparented in Part::slotShowBottomBar() when the page bar is shown or hidden.
> 
> The page tool is placed in its own toolbar by default, so that it can be positioned or floated in accordance with the user's preference.
> 
> There are GUI changes and a new I18N string, so this change (if accepted) would be targeted at KDE SC 4.8.1 or later.
> 
> 
> This addresses bug 279128.
>     http://bugs.kde.org/show_bug.cgi?id=279128
> 
> 
> Diffs
> -----
> 
>   part.rc 33d3829 
>   part.cpp b3b4234 
>   part-viewermode.rc dbd8e42 
>   part.h cae5af0 
> 
> Diff: http://git.reviewboard.kde.org/r/103427/diff/diff
> 
> 
> Testing
> -------
> 
> Built Okular from master with these changes.  Checked operation in both embedded and standalone modes with page bar shown or not, with a variety of PDF files.
> 
> 
> Screenshots
> -----------
> 
> With page bar shown
>   http://git.reviewboard.kde.org/r/103427/s/372/
> With page bar hidden
>   http://git.reviewboard.kde.org/r/103427/s/373/
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120122/7869feee/attachment.html>