[Okular-devel] Review Request: Remove unneeded code for handling screensaver inhibition, and rename methods

Dario Freddi drf at kde.org
Wed Jan 18 05:25:06 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103723/
-----------------------------------------------------------

Review request for Okular.


Description
-------

This follows my previous review. After commit https://projects.kde.org/projects/kde/kdelibs/repository/revisions/20907e8a2433d5a82560c093531fbe288ecc10ec , Solid's APIs also inhibit screensaver. This removes now redundant code in okular, and renames the inhibition/allowance methods for more clarity.


Diffs
-----

  ui/presentationwidget.h eac2731 
  ui/presentationwidget.cpp cdcfc4b 

Diff: http://git.reviewboard.kde.org/r/103723/diff/diff


Testing
-------


Thanks,

Dario Freddi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120118/c78586bd/attachment.html>


More information about the Okular-devel mailing list