[Okular-devel] Review Request: Comicbook: Simplify mimetype queries

[David Palacio]

> On Feb. 11, 2012, 6:40 p.m., Harsh Chouraria J wrote:
> > generators/comicbook/document.cpp, line 72
> > <http://git.reviewboard.kde.org/r/103941/diff/1/?file=49242#file49242line72>
> >
> >     Does the check of "x-compressed-tar" not cover "x-bzip-compressed-tar"?

No, application/x-bzip-compressed-tar inherits application/x-bzip and application/x-compressed-tar only covers gzip compressed tars.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103941/#review10513
-----------------------------------------------------------


On Feb. 11, 2012, 5:59 p.m., David Palacio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103941/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2012, 5:59 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> Simplify mimetype queries.
> 
> String comparisons are not recommended by KMimeType class. KMimeType::is() also hadles type inheritance. E.g.:
>   application/x-cbt inherits application/x-tar
> 
> 
> Diffs
> -----
> 
>   generators/comicbook/document.cpp 3ba7483 
> 
> Diff: http://git.reviewboard.kde.org/r/103941/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Palacio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120211/bc2a625e/attachment.html>