[Okular-devel] Review Request: Comicbook: Open rar and 7z archives with The Unarchiver

[Harsh Chouraria J]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103942/#review10512
-----------------------------------------------------------


Hi,

Nice changes.

Whats the uptake of the unar/lsar utils in distros? Are they available packaged in at least the two tiers of most popular used distributions?


generators/comicbook/document.cpp
<http://git.reviewboard.kde.org/r/103942/#comment8594>

    Isn't there a chance for "unar"/"lsar" programs to not exist on a given distribution?
    
    We would need equivalent checks for the same.


- Harsh Chouraria J


On Feb. 11, 2012, 6:02 p.m., David Palacio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103942/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2012, 6:02 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> This change replaces the different rar archives decompressors with "unar", the commandline decompressor from The Unarchiver[1]. Support for 7z/cb7 archives is added as well.
> 
> This diff is based on the "Simplify mimetype queries" diff.
> 
> [1] http://wakaba.c3.cx/s/apps/unarchiver
> 
> 
> Diffs
> -----
> 
>   generators/comicbook/CMakeLists.txt 067a07a 
>   generators/comicbook/document.h 22c3213 
>   generators/comicbook/document.cpp 3ba7483 
>   generators/comicbook/libokularGenerator_comicbook.desktop bec8c92 
>   generators/comicbook/okularApplication_comicbook.desktop 285f19d 
>   generators/comicbook/okularComicbook.desktop 4d70d70 
>   generators/comicbook/unar.h PRE-CREATION 
>   generators/comicbook/unar.cpp PRE-CREATION 
>   generators/comicbook/unrar.h d0fca3c 
>   generators/comicbook/unrar.cpp 27cc6af 
>   generators/comicbook/unrarflavours.h 974cd04 
>   generators/comicbook/unrarflavours.cpp 7451321 
> 
> Diff: http://git.reviewboard.kde.org/r/103942/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Palacio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120211/5ce9890a/attachment-0001.html>