[Okular-devel] Review Request: Comicbook: Simplify mimetype queries
David Palacio
dpalacio at orbitalibre.org
Sat Feb 11 17:59:50 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103941/
-----------------------------------------------------------
Review request for Okular.
Description
-------
Simplify mimetype queries.
String comparisons are not recommended by KMimeType class. KMimeType::is() also hadles type inheritance. E.g.:
application/x-cbt inherits application/x-tar
Diffs
-----
generators/comicbook/document.cpp 3ba7483
Diff: http://git.reviewboard.kde.org/r/103941/diff/
Testing
-------
Thanks,
David Palacio
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120211/088d6d37/attachment.html>
More information about the Okular-devel
mailing list