[Okular-devel] Review Request: Settings separation: observer.h install and compilation correction on Windows

[Albert Astals Cid]

> On Nov. 1, 2012, 4:36 p.m., Albert Astals Cid wrote:
> > conf/settings.kcfgc, line 7
> > <http://git.reviewboard.kde.org/r/107047/diff/2/?file=92392#file92392line7>
> >
> >     SettingsCore is part of libokularcore, so using OKULAR_EXPORT is fine, no?
> 
> Bogdan Cristea wrote:
>     settings_core.h exposes methods found in okularcore library, while settings.h exposes methods found in okularpart library. In Windows, when the second library is build, settings_core.h should import its symbols, while settings.h should export them. For Linux there is no problem since all library symbols are exported by default.
> 
> Albert Astals Cid wrote:
>     Oh sorry, this is for settings.kcfgc, not for settings_core.kcfgc
>     
>     Still, we are not installing settings.h so can't we just drop the visibility? I.e. other classes of the part like part.h have no visibility definition, no?

Bogdan?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107047/#review21327
-----------------------------------------------------------


On Oct. 26, 2012, 7:57 a.m., Bogdan Cristea wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107047/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2012, 7:57 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> This patch is related to settings separation for the frontend and the backend. It proposes the installation of core/observer.h and corrects compilation of okular on Windows (using KDE on windows):
> - after separation, settings.h and settings_core.h need to use different precompiler switches for exporting/importing symbols
> - add definitions needed to activate these switches on Windows
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 063778f 
>   active/components/CMakeLists.txt 19b759e 
>   conf/settings.kcfgc 5e2ec95 
>   okular_part_export.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/107047/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Bogdan Cristea
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20121231/feb301e4/attachment.html>