[Okular-devel] Review Request: Don't ignore mouse movements on the annotator when not on the locked item

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107726/#review23563
-----------------------------------------------------------


This review has been submitted with commit 1ef6929344a423a837aa9fff56524706220def56 by Albert Astals Cid to branch master.

- Commit Hook


On Dec. 14, 2012, 6:39 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107726/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2012, 6:39 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> Since we lock the item in the annotator there is no need to ignore the move movements when we are out of the annotator. I've tested the annotations and
> they all work "fine" with the limitation of the annotation only affects the page that the annotation was started (which is already a limitation) and the problem of the "Note" that you can really put "outside" of the page.
> 
> If we agree this is fine i'll "fix" the "Note" so you can not drag it outside the page.
> 
> And maybe we can "improve" the other annotations not to give the impression that the annotation will go over the other pages too.
> 
> Comments?
> 
> 
> This addresses bug 310572.
>     http://bugs.kde.org/show_bug.cgi?id=310572
> 
> 
> Diffs
> -----
> 
>   ui/pageviewannotator.cpp 4488639 
> 
> Diff: http://git.reviewboard.kde.org/r/107726/diff/
> 
> 
> Testing
> -------
> 
> Run all the default annotations with the outcome above described
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20121216/1ed85515/attachment.html>