[Okular-devel] Review Request: Fix for the bug-166645

[Albert Astals Cid]

> On Aug. 17, 2012, 11:19 p.m., Albert Astals Cid wrote:
> > part.cpp, line 930
> > <http://git.reviewboard.kde.org/r/105965/diff/6/?file=78056#file78056line930>
> >
> >     I'd prefer if you left it in openUrl, i see no reason for moving it to a different function. What's your rationale for the move?
> 
> Jaydeep Solanki wrote:
>     because, I want the current (Open) document to close only when the user drags a file inside okular window.

But that is wrong, openUrl is a public part function, what would happen when someone that is not okular embedds the okular part and uses that function twice? 


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105965/#review17632
-----------------------------------------------------------


On Aug. 20, 2012, 8:27 p.m., Jaydeep Solanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105965/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2012, 8:27 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> This patch is a fix for the bug-166645, as listed here (https://bugs.kde.org/show_bug.cgi?id=166645)
> 
> Opens a new instance of Okular for every other file that is opened.
> 
> 
> Diffs
> -----
> 
>   part.h d9a5cc4 
>   part.cpp 7c1ca71 
>   shell/shell.h 8430b9c 
>   shell/shell.cpp 8b99ce4 
> 
> Diff: http://git.reviewboard.kde.org/r/105965/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jaydeep Solanki
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120820/f5678b28/attachment-0001.html>