[Okular-devel] Review Request: Implement the handling of page rotations for source references

[Michel Ludwig]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103060/
-----------------------------------------------------------

(Updated Aug. 19, 2012, 8:52 a.m.)


Review request for Okular.


Changes
-------

Make the ThumbnailList work better with rotated pages.

Albert, can you please check if you are happy with it? There seem to be some corner cases regarding the 'Facing Pages' modes around pages 1/2 in Rotation90 or Rotation270, which look somehow ok to me in the way they are handled now, but maybe you don't like it ;)


Description
-------

Implement the handling of page rotations for source references.


Diffs (updated)
-----

  core/document.h 85cd821 
  core/document.cpp f6bf699 
  core/page.h a8f2761 
  core/page.cpp ca40d92 
  core/utils.h 8d5d5fc 
  core/utils.cpp 5dd8448 
  generators/dvi/generator_dvi.cpp 5cd327f 
  generators/poppler/generator_pdf.cpp 71c962c 
  part.cpp 7c1ca71 
  ui/pagepainter.cpp 537e5c5 
  ui/pageview.h 43ca2ab 
  ui/pageview.cpp 5e04412 
  ui/side_reviews.cpp a036c48 
  ui/thumbnaillist.cpp 8b23025 

Diff: http://git.reviewboard.kde.org/r/103060/diff/


Testing
-------


Thanks,

Michel Ludwig

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120819/98e89151/attachment-0001.html>