[Okular-devel] Review Request: Fix for the bug-166645

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105965/#review17632
-----------------------------------------------------------



part.cpp
<http://git.reviewboard.kde.org/r/105965/#comment13800>

    I'd prefer if you left it in openUrl, i see no reason for moving it to a different function. What's your rationale for the move?



part.rc
<http://git.reviewboard.kde.org/r/105965/#comment13799>

    You should not need this one.



shell/shell.cpp
<http://git.reviewboard.kde.org/r/105965/#comment13801>

    Maybe use !.isEmpty()? This way we save the need of constructing a KUrl



shell/shell.rc
<http://git.reviewboard.kde.org/r/105965/#comment13803>

    Can you please increase the version number?


- Albert Astals Cid


On Aug. 15, 2012, 10:05 p.m., Jaydeep Solanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105965/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2012, 10:05 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> This patch is a fix for the bug-166645, as listed here (https://bugs.kde.org/show_bug.cgi?id=166645)
> 
> Opens a new instance of Okular for every other file that is opened.
> 
> 
> Diffs
> -----
> 
>   part.h d9a5cc4 
>   part.cpp 7c1ca71 
>   part.rc 33d3829 
>   shell/shell.cpp 8b42a27 
>   shell/shell.rc 93fbc41 
> 
> Diff: http://git.reviewboard.kde.org/r/105965/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jaydeep Solanki
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120817/3ed2f05b/attachment-0001.html>