[Okular-devel] Review Request: Add different modes to AnnotationPopup

[Fabio D'Urso]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106045/#review17459
-----------------------------------------------------------



ui/annotationpopup.h
<http://git.reviewboard.kde.org/r/106045/#comment13656>

    In the doc comment: a single annotation, or multiple annotations as a group



ui/annotationpopup.h
<http://git.reviewboard.kde.org/r/106045/#comment13653>

    explicit is not needed anymore, because the ctor now takes at least two arguments



ui/annotationpopup.cpp
<http://git.reviewboard.kde.org/r/106045/#comment13655>

    In MultiAnnotationMode, this separator is not present. Personally, I prefer no separator.


- Fabio D'Urso


On Aug. 15, 2012, 4:08 p.m., Tobias Koenig wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106045/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2012, 4:08 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> Since the side review pane has different needs for the structure of the RMB menu than the page view, this patch adds an enum parameter to the ctor of AnnotationPopup that switches between the old mode (used for review pane) and the new mode (used for page view).
> 
> 
> Diffs
> -----
> 
>   ui/annotationpopup.h 9856933 
>   ui/annotationpopup.cpp 6d00004 
>   ui/pageview.cpp e158b60 
>   ui/side_reviews.cpp fc4b307 
> 
> Diff: http://git.reviewboard.kde.org/r/106045/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tobias Koenig
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120815/c2a480c3/attachment.html>