[Okular-devel] Review Request: Fix for the bug-166645

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105965/#review17447
-----------------------------------------------------------



part.cpp
<http://git.reviewboard.kde.org/r/105965/#comment13647>

    This is wrong, You don't need to add the action if it's a StandardAction, see how we don't need it for saveAs



part.cpp
<http://git.reviewboard.kde.org/r/105965/#comment13648>

    This is wrong, what happens with the openUrlFromDocument calls?



part.rc
<http://git.reviewboard.kde.org/r/105965/#comment13646>

    This is wrong, you are using a standard action, so use its standard name "file_close"
    
    Besides it should not go to the "file_save" group but to the "file_close" one, that you need to define in the shell as
       <DefineGroup append="close_merge" name="file_close" />
    



shell/shell.cpp
<http://git.reviewboard.kde.org/r/105965/#comment13649>

    This is not what i meant. And this probably won't work since what will happen when you open a file from http:// ? What i meant was using the Document::isOpened information


- Albert Astals Cid


On Aug. 14, 2012, 11:30 p.m., Jaydeep Solanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105965/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2012, 11:30 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> This patch is a fix for the bug-166645, as listed here (https://bugs.kde.org/show_bug.cgi?id=166645)
> 
> Opens a new instance of Okular for every other file that is opened.
> 
> 
> Diffs
> -----
> 
>   part.h d9a5cc4 
>   part.cpp 7c1ca71 
>   part.rc 33d3829 
>   shell/shell.cpp df40f7d 
> 
> Diff: http://git.reviewboard.kde.org/r/105965/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jaydeep Solanki
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120815/fab31ca9/attachment-0001.html>