[Okular-devel] Review Request: Fix for the bug-166645

Albert Astals Cid tsdgeos at terra.es
Tue Aug 14 22:58:45 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105965/#review17421
-----------------------------------------------------------


I think reviewboard got confused with your diff since it's shwoing a diff that removes lines that are not there in the file in the first time.

Can you please reupload the diff making sure it's the diff between what there is on master or KDE/4.9 branches and your desired code?

- Albert Astals Cid


On Aug. 14, 2012, 10:09 p.m., Jaydeep Solanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105965/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2012, 10:09 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> This patch is a fix for the bug-166645, as listed here (https://bugs.kde.org/show_bug.cgi?id=166645)
> 
> Opens a new instance of Okular for every other file that is opened.
> 
> 
> Diffs
> -----
> 
>   part.h d9a5cc4 
>   part.cpp 7c1ca71 
>   shell/shell.h 8430b9c 
>   shell/shell.cpp 8b42a27 
> 
> Diff: http://git.reviewboard.kde.org/r/105965/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jaydeep Solanki
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120814/8f2bdc48/attachment.html>


More information about the Okular-devel mailing list