[Okular-devel] Review Request: Fix for the bug-166645

Jaydeep Solanki jaydp17 at gmail.com
Sun Aug 12 20:25:30 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105965/
-----------------------------------------------------------

(Updated Aug. 12, 2012, 8:25 p.m.)


Review request for Okular.


Changes
-------

Yes you were correct, I didn't set m_onefileOpen to false anywhere in the code, because there was no way to close the document (not the window).
So now I have implemented a "Close Document" action in the File Menu, which closes only the document not the window, that is where m_onefileOpen is set to false.


Description
-------

This patch is a fix for the bug-166645, as listed here (https://bugs.kde.org/show_bug.cgi?id=166645)

Opens a new instance of Okular for every other file that is opened.


Diffs (updated)
-----

  part.h d9a5cc4 
  part.cpp 7c1ca71 
  part.cpp 612193c 
  part.rc 33d3829 
  shell/main.cpp 0ded376 
  shell/main.cpp 0ded376 
  shell/shell.h 8430b9c 
  shell/shell.h 8430b9c 
  shell/shell.cpp 8b42a27 
  shell/shell.cpp 8b42a27 

Diff: http://git.reviewboard.kde.org/r/105965/diff/


Testing
-------


Thanks,

Jaydeep Solanki

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120812/703ddff8/attachment-0001.html>


More information about the Okular-devel mailing list