[Okular-devel] Review Request: Implement the poster functionality for videos embedded in PDF files
Albert Astals Cid
tsdgeos at terra.es
Fri Aug 10 21:00:36 UTC 2012
> On Aug. 8, 2012, 10:22 p.m., Albert Astals Cid wrote:
> > I just gave it a try with the file of the attached bug and noticed two things:
> > a) It doesn't work, i don't get any poster image
> > b) I get for a while a "flying" widget over the okular window (argably the snapshot taker)
> >
> > Does it work for you? Which phonon are you using?
>
> Tobias Koenig wrote:
> You have to use a phonon backend that supports the snapshot() method in its VideoWidget interface. That's the case for the latest version of the vlc-backend (which I also use).
>
> Do you use gstreamer?
Does my phonon backend support snapshot()? -> No clue, how do i know?
Do I use gstreamer -> Yes
Can we detect that snapshot() support and if not there do not popup ugly widgets in my face?
- Albert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105890/#review17128
-----------------------------------------------------------
On Aug. 8, 2012, 9:23 a.m., Tobias Koenig wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105890/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2012, 9:23 a.m.)
>
>
> Review request for Okular and Albert Astals Cid.
>
>
> Description
> -------
>
> The patch extends the VideoWidget to either show the actual video player and keep it hidden while not playing (in non-poster mode) or show an image of the first frame all the time and overlay it with the video player (in poster mode).
>
>
> Diffs
> -----
>
> CMakeLists.txt e4cb88f
> cmake/modules/FindPoppler.cmake ffa6950
> core/movie.h cbe382e
> core/movie.cpp 94e71a9
> generators/poppler/config-okular-poppler.h.cmake df89d68
> generators/poppler/generator_pdf.cpp 71c962c
> ui/pageview.cpp b74941d
> ui/presentationwidget.cpp f4da539
> ui/snapshottaker.h PRE-CREATION
> ui/snapshottaker.cpp PRE-CREATION
> ui/videowidget.h e82753c
> ui/videowidget.cpp 7d80b43
>
> Diff: http://git.reviewboard.kde.org/r/105890/diff/
>
>
> Testing
> -------
>
> Using the files provided as attachment in https://bugs.kde.org/show_bug.cgi?id=301603
>
>
> Thanks,
>
> Tobias Koenig
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120810/67007b3e/attachment.html>
More information about the Okular-devel
mailing list