[Okular-devel] Review Request: Implement the poster functionality for videos embedded in PDF files

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105890/#review17083
-----------------------------------------------------------


Besides the seek question  it is a great patch :-)


core/movie.h
<http://git.reviewboard.kde.org/r/105890/#comment13388>

    Missing since



core/movie.h
<http://git.reviewboard.kde.org/r/105890/#comment13389>

    Missing since



core/movie.h
<http://git.reviewboard.kde.org/r/105890/#comment13390>

    Missing since



core/movie.h
<http://git.reviewboard.kde.org/r/105890/#comment13391>

    Missing since



ui/snapshottaker.cpp
<http://git.reviewboard.kde.org/r/105890/#comment13387>

    1 is msec or sec? Why we need this?


- Albert Astals Cid


On Aug. 7, 2012, 9:21 a.m., Tobias Koenig wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105890/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2012, 9:21 a.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Description
> -------
> 
> The patch extends the VideoWidget to either show the actual video player and keep it hidden while not playing (in non-poster mode) or show an image of the first frame all the time and overlay it with the video player (in poster mode).
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e4cb88f 
>   cmake/modules/FindPoppler.cmake ffa6950 
>   core/movie.h cbe382e 
>   core/movie.cpp 94e71a9 
>   generators/poppler/config-okular-poppler.h.cmake df89d68 
>   generators/poppler/generator_pdf.cpp a7b86eb 
>   ui/pageview.cpp b74941d 
>   ui/presentationwidget.cpp f4da539 
>   ui/snapshottaker.h PRE-CREATION 
>   ui/snapshottaker.cpp PRE-CREATION 
>   ui/videowidget.h e82753c 
>   ui/videowidget.cpp 7d80b43 
> 
> Diff: http://git.reviewboard.kde.org/r/105890/diff/
> 
> 
> Testing
> -------
> 
> Using the files provided as attachment in https://bugs.kde.org/show_bug.cgi?id=301603
> 
> 
> Thanks,
> 
> Tobias Koenig
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120807/db733f4e/attachment.html>