[Okular-devel] [PATCHES] Customizable annotation tools

[Albert Astals Cid]

El Dimecres, 1 d'agost de 2012, a les 03:04:31, Fabio D'Urso va escriure:
> On Wednesday, August 01, 2012 12:32:06 AM Albert Astals Cid wrote:
> > Can we see screenshots of the other GUI changes you made for lazy people?
> 
> Annotation widget changes (in all images old is on the left):
> - Do not show the font selection field in pop-up annotations (cmp-popup)
>    I guess it was a forgotten if, because the same widget is used for
>    inplace text annotations, where configuring the font makes sense.
> - Configurable line width in InkAnnotations (cmp-ink)
> - Configurable inner color in polygons (cmp-polygon)
>    Note that even tough straight lines and polylines use the same widget,
>    the inner color field is not shown in those annotations. In other words,
>    their properties dialog were not changed.
> - Text alignment in inplace text annotations (cmp-inplace)
>    This one can be done better (eg with icons) in future patches. I had had
> a quick look at koffice source and I remember that there were different
> cases for LTR and RTL languages, that's why I went the easy path.
> 
> The Identity configuration page is replaced by an Annotations page, which
> contains the configurable tool list. You can see it in config-panel-new.
> Note that the privacy notice now appears as tooltip for text box.
> 
> In config-panel-new, you can also see the dialog to create and edit tools.
> As I said in the previous post, it uses the same widgets used by the
> annotation properties dialog.
> The caption is "Edit annotation tool" if the user is editing an existing
> tool (like in the picture), or "Create annotation tool" if the user is
> creating a new tool.
> If the user hasn't set a customized name, the Name text box shows the
> default tool name in gray (placeholder text).
> The combo lets you choose the tool type. Changing its value also changes the
> type of properties that can be configured. Available choices are: Pop-up
> Note, Inline Note, Freehand Line, Straight Line, Polygon, Polyline, Text
> markup, Geometrical shape, Stamp.
> 
> In this dialog, I used the term "Freehand Line" instead of "Ink", and
> "Straight Line", "Polygon" and "Polyline" instead of the generic "Line"
> which is used in the annotation properties dialog, because they sound
> clearer to me. If you agree, I'd make another patch to make the annotation
> properties dialog show these names too.
> 
> > It might be good adding some contents to
> > PageViewAnnotator::defaultToolName
> > since e.g. "Underline" can be read as a verb or as a noun.
> 
> Yes, I see the issue. Currently we have Highlighter, but also Polygon,
> Stamp, Underlining and Ellipse, that are all nouns. I'll review that part.
> > What happens when there are lots of items in the toolbar, do you get a
> > double line of icons?
> 
> Yes. I didn't change it and the existing code can do that (toolbar-wrap).
> 
> P.S.: I'd like to change the Polygon icon too, because it's not a polygon
> right now.

Works for me (as in "I agree to everything you say")

Cheers,
  Albert

> 
> Fabio