[Okular-devel] Review Request: Don't call delete m_part; if m_part is NULL.

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105905/#review17008
-----------------------------------------------------------


Not needed, delete NULL; is perfectly fine

- Albert Astals Cid


On Aug. 6, 2012, 11:29 p.m., Michael Reeves wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105905/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2012, 11:29 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> Don't call delete m_part; if m_part is NULL.
> 
> 
> Diffs
> -----
> 
>   shell/shell.cpp 8b42a27 
> 
> Diff: http://git.reviewboard.kde.org/r/105905/diff/
> 
> 
> Testing
> -------
> 
> This seemed to be an oversight the patch just adds brackets to an existing null pointer check two lines earlier.
> 
> 
> Thanks,
> 
> Michael Reeves
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120806/82d4b156/attachment.html>