[Okular-devel] Review Request: Implement the handling of page rotations for source references

[Michel Ludwig]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103060/
-----------------------------------------------------------

(Updated Nov. 20, 2011, 11:22 a.m.)


Review request for Okular.


Changes
-------

Viewports should now be restored correctly.

The code in 'thumbnaillists.cpp' should now work better with rotations. There are two issues left with it, however:

- 'ThumbnailListPrivate::getNewPageOffset' still has to be updated to work with Rotation180
- There is currently no code for switching pages in either Rotation90 or Rotation270


Description
-------

Implement the handling of page rotations for source references.


Diffs (updated)
-----

  core/document.h 78ce53a 
  core/document.cpp b3ddb46 
  core/page.h 46fba72 
  core/page.cpp bb3dbbd 
  core/utils.h 8d5d5fc 
  core/utils.cpp 5dd8448 
  generators/dvi/generator_dvi.cpp 16d124b 
  generators/poppler/generator_pdf.cpp d88da80 
  part.cpp 2c0c70b 
  ui/pagepainter.cpp ca55e81 
  ui/pageview.h 63b0af0 
  ui/pageview.cpp 56be30d 
  ui/side_reviews.cpp 40a7adf 
  ui/thumbnaillist.cpp 60a43c4 

Diff: http://git.reviewboard.kde.org/r/103060/diff/diff


Testing
-------


Thanks,

Michel Ludwig

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20111120/108cb8df/attachment.html>