[Okular-devel] Review Request: Implement the handling of page rotations for source references

Michel Ludwig michel.ludwig at gmail.com
Sun Nov 13 18:23:18 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103060/
-----------------------------------------------------------

(Updated Nov. 13, 2011, 6:23 p.m.)


Review request for Okular.


Changes
-------

Ensure that coordinates are relative to Rotation0 when storing them in viewports.

I didn't go through 'thumbnaillist.cpp' yet as I don't really understand the code. Maybe someone else can do that? :)

All other occurrences should be covered.


Description
-------

Implement the handling of page rotations for source references.


Diffs (updated)
-----

  core/document.h 78ce53a 
  core/document.cpp b3ddb46 
  core/page.h 46fba72 
  core/page.cpp bb3dbbd 
  core/utils.h 8d5d5fc 
  core/utils.cpp 5dd8448 
  generators/dvi/generator_dvi.cpp 2bc8641 
  generators/poppler/generator_pdf.cpp d88da80 
  part.cpp 2c0c70b 
  ui/pagepainter.cpp ca55e81 
  ui/pageview.cpp 0c0ff98 
  ui/side_reviews.cpp 40a7adf 
  ui/thumbnaillist.cpp 60a43c4 

Diff: http://git.reviewboard.kde.org/r/103060/diff/diff


Testing
-------


Thanks,

Michel Ludwig

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20111113/51d48dfe/attachment.html>


More information about the Okular-devel mailing list