[Okular-devel] Review Request: Comicbook generator does not open archives

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103070/#review8047
-----------------------------------------------------------

Ship it!


If you have tried it and it works, go ahead and commit it, can not find anything wrong in the patch.

Thanks!

- Albert Astals Cid


On Nov. 8, 2011, 6:48 p.m., David Palacio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103070/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2011, 6:48 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> Commit 39fc2a471e7cbbe4337ad095add6418b6bda256b introduced a change that only works with directories (i.e. not archives, zip, rar, etc.). It also makes a QImageReader test for each file twice, in extractImageFiles and pageSize. This change handles all cases (directories, zip, tar and rar) and does only one QImageReader test by merging extractImageFiles, pageSize and pages methods.
> 
> 
> Diffs
> -----
> 
>   generators/comicbook/document.h 1a1c72c 
>   generators/comicbook/document.cpp 75c4334 
>   generators/comicbook/generator_comicbook.cpp d0b7b35 
> 
> Diff: http://git.reviewboard.kde.org/r/103070/diff/diff
> 
> 
> Testing
> -------
> 
> Tested on master for Directories, Zip and Rar.
> 
> 
> Thanks,
> 
> David Palacio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20111109/2bf2e41b/attachment.html>