[Okular-devel] Review Request: Comicbook generator does not open archives

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103070/#review8026
-----------------------------------------------------------



generators/comicbook/document.h
<http://git.reviewboard.kde.org/r/103070/#comment6913>

    It would prefer if it was a * instead of a &, it is usually how output parameters are used in Qt based APIs



generators/comicbook/document.cpp
<http://git.reviewboard.kde.org/r/103070/#comment6915>

    Might make sense to clear the pagesVector just to be sure that future uses do not yield unexpected results



generators/comicbook/document.cpp
<http://git.reviewboard.kde.org/r/103070/#comment6914>

    Can you try to use QScopedPointer instead of std::auto_ptr?



generators/comicbook/document.cpp
<http://git.reviewboard.kde.org/r/103070/#comment6916>

    Why clear here? For me it makes sense that if I call pages twice i should get the same result, not an empty result the second time.


- Albert Astals Cid


On Nov. 7, 2011, 9:10 p.m., David Palacio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103070/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2011, 9:10 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> Commit 39fc2a471e7cbbe4337ad095add6418b6bda256b introduced a change that only works with directories (i.e. not archives, zip, rar, etc.). It also makes a QImageReader test for each file twice, in extractImageFiles and pageSize. This change handles all cases (directories, zip, tar and rar) and does only one QImageReader test by merging extractImageFiles, pageSize and pages methods.
> 
> 
> Diffs
> -----
> 
>   generators/comicbook/document.h 1a1c72c 
>   generators/comicbook/document.cpp 75c4334 
>   generators/comicbook/generator_comicbook.cpp d0b7b35 
> 
> Diff: http://git.reviewboard.kde.org/r/103070/diff/diff
> 
> 
> Testing
> -------
> 
> Tested on master for Directories, Zip and Rar.
> 
> 
> Thanks,
> 
> David Palacio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20111108/dcf371e8/attachment.html>