[Okular-devel] Review Request: Merge request for 'viewerinterface' branch

[Albert Astals Cid]

> On Nov. 2, 2011, 12:20 a.m., Albert Astals Cid wrote:
> > Ok, seems i can not see anything obviously wrong, let's ship it and see if users find anything wrong ;-)
> 
> Albert Astals Cid wrote:
>     Actually, before merging it, could you remove the embed mode from core/global.h? It does not make much sense to be there since the "core" library does not care at all about the embedding mode, it is more of a ui thing. Maybe part.h is enough for it?
> 
> Michel Ludwig wrote:
>     It's just that I would need those in the dialog classes (conf/preferencesdialog.h). Is there any other place I could put the embedding mode definitions?

part.h, you can include part.h from the conf files since they are part of the part


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102946/#review7851
-----------------------------------------------------------


On Nov. 1, 2011, 9:17 p.m., Michel Ludwig wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102946/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2011, 9:17 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> The functionality that I need for Kile should now be implemented, i.e. handling of source references, disabling of certain actions and configuration options in 'ViewerWidgetMode', and drawing of source locations.
> 
> Note that currently the drawing of source locations doesn't work correctly for rotated pages. This is due to the fact that locating source references for rotated doesn't seem to be implemented in Okular yet. I'm thinking of disabling the rotate-page actions in 'ViewerWidgetMode' until this is implemented in Okular.
> 
> If you want to see the viewer mode in action, you can try it out by following the instructions given here:
> 
> http://sourceforge.net/apps/mediawiki/kile/index.php?title=Live_Preview
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt f8dcba0 
>   conf/dlggeneral.h 1ee2768 
>   conf/dlggeneral.cpp 80478e6 
>   conf/okular.kcfg b7d511c 
>   conf/preferencesdialog.h 72a7072 
>   conf/preferencesdialog.cpp 5ea6269 
>   core/document.h 2bcf280 
>   core/document.cpp a417828 
>   core/global.h 24cef77 
>   interfaces/viewerinterface.h PRE-CREATION 
>   part-viewermode.rc PRE-CREATION 
>   part.h f6203d7 
>   part.cpp 275bf4d 
>   ui/pagepainter.h 4044dd8 
>   ui/pagepainter.cpp 2bd2f23 
>   ui/pageview.h 9800c55 
>   ui/pageview.cpp 2a17369 
> 
> Diff: http://git.reviewboard.kde.org/r/102946/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michel Ludwig
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20111102/266c37a0/attachment.html>