[Okular-devel] Review Request: Merge request for 'viewerinterface' branch

Michel Ludwig michel.ludwig at gmail.com
Tue Nov 1 21:17:52 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102946/
-----------------------------------------------------------

(Updated Nov. 1, 2011, 9:17 p.m.)


Review request for Okular.


Description
-------

The functionality that I need for Kile should now be implemented, i.e. handling of source references, disabling of certain actions and configuration options in 'ViewerWidgetMode', and drawing of source locations.

Note that currently the drawing of source locations doesn't work correctly for rotated pages. This is due to the fact that locating source references for rotated doesn't seem to be implemented in Okular yet. I'm thinking of disabling the rotate-page actions in 'ViewerWidgetMode' until this is implemented in Okular.

If you want to see the viewer mode in action, you can try it out by following the instructions given here:

http://sourceforge.net/apps/mediawiki/kile/index.php?title=Live_Preview


Diffs (updated)
-----

  CMakeLists.txt f8dcba0 
  conf/dlggeneral.h 1ee2768 
  conf/dlggeneral.cpp 80478e6 
  conf/okular.kcfg b7d511c 
  conf/preferencesdialog.h 72a7072 
  conf/preferencesdialog.cpp 5ea6269 
  core/document.h 2bcf280 
  core/document.cpp a417828 
  core/global.h 24cef77 
  interfaces/viewerinterface.h PRE-CREATION 
  part-viewermode.rc PRE-CREATION 
  part.h f6203d7 
  part.cpp 275bf4d 
  ui/pagepainter.h 4044dd8 
  ui/pagepainter.cpp 2bd2f23 
  ui/pageview.h 9800c55 
  ui/pageview.cpp 2a17369 

Diff: http://git.reviewboard.kde.org/r/102946/diff/diff


Testing
-------


Thanks,

Michel Ludwig

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20111101/16c9ef01/attachment.html>


More information about the Okular-devel mailing list