[Okular-devel] Re: Patch for bug 24887 and 270524

[Albert Astals Cid]

A Thursday, June 16, 2011, Christopher Reichert va escriure:
> Awesome. I committed the patch and cc'ed the bug reports involved although
> I don't think I have the proper permissions to close a bug and edit the
> "fixed in" string.

I've closed them both, for the next time we need you to give me your bugzilla 
user so we can give you some more permissions.

Albert

> 
> 
> https://bugs.kde.org/show_bug.cgi?id=270524
> 
> https://bugs.kde.org/show_bug.cgi?id=274887
> 
> On Wed, Jun 15, 2011 at 4:47 PM, Albert Astals Cid <aacid at kde.org> wrote:
> > A Monday, June 13, 2011, Burkhard Lück va escriure:
> > > Am Montag, 13. Juni 2011, um 23:12:12 schrieb Albert Astals Cid:
> > > > A Friday, June 10, 2011, Christopher Reichert va escriure:
> > > > > Attached the patch. Apologies.
> > > > 
> > > > Looks good to me, i'm not sure if this should go in for 4.7 at this
> > 
> > stage
> > 
> > > > given the "feature freeze" stage, though we could probably consider
> > 
> > this
> > 
> > > > an "usability bugfix", comments?
> > > 
> > > From a user POV I would qualify this a "usability bugfix", should
> > > definitely go into 4.7, and wrt the code changes I trust you as
> > > developer...
> > 
> > Ok, since noone has complained i think that you can commit it to master.
> > Do not forget to close the bugs after the commit and set the fixed
> > version to 4.7.0
> > 
> > Albert
> > _______________________________________________
> > Okular-devel mailing list
> > Okular-devel at kde.org
> > https://mail.kde.org/mailman/listinfo/okular-devel