[Okular-devel] Re: Review Request: Fix landscape documents getting printed in portrait format if "Landscape" is selected in the print dialog (the default).

Albert Astals Cid tsdgeos at terra.es
Mon Jun 6 01:30:00 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101513/#review3697
-----------------------------------------------------------


A PDF that helped me when fixing printing in KPDF http://cgit.freedesktop.org/poppler/test/plain/unittestcases/orientation.pdf

Of course that's just a small PDF, lots of other file formats and page formats need to be tested

- Albert


On June 5, 2011, 10:54 p.m., Kevin Kofler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101513/
> -----------------------------------------------------------
> 
> (Updated June 5, 2011, 10:54 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Summary
> -------
> 
> Fix landscape documents getting printed in portrait format if "Landscape" is selected in the print dialog (the default).
>     
> Partly based on a patch by Falk from KDE bug #181290.
> 
> 
> This addresses bug 181290.
>     http://bugs.kde.org/show_bug.cgi?id=181290
> 
> 
> Diffs
> -----
> 
>   core/document.h 587c03c 
>   core/document.cpp 8af1840 
>   core/fileprinter.h f17e09d 
>   core/fileprinter.cpp f08b104 
>   generators/djvu/generator_djvu.cpp f05c0eb 
>   generators/dvi/dviexport.cpp f866559 
>   generators/poppler/generator_pdf.cpp 42bad00 
>   generators/spectre/generator_ghostview.cpp 7150df8 
>   part.cpp cf0edfa 
> 
> Diff: http://git.reviewboard.kde.org/r/101513/diff
> 
> 
> Testing
> -------
> 
> None yet.
> 
> 
> Thanks,
> 
> Kevin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/okular-devel/attachments/20110605/3e40caeb/attachment.htm 


More information about the Okular-devel mailing list