[Okular-devel] Re: Review Request: Fix landscape documents getting printed in portrait format if "Landscape" is selected in the print dialog (the default).

[Kevin Kofler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101513/
-----------------------------------------------------------

(Updated July 27, 2011, 11:01 p.m.)


Review request for Okular.


Changes
-------

Fix the signature of the new printFile overload to put the non-optional argument before the optional ones.
(It won't compile otherwise.)


Summary
-------

Fix landscape documents getting printed in portrait format if "Landscape" is selected in the print dialog (the default).
    
Partly based on a patch by Falk from KDE bug #181290.


This addresses bug 181290.
    http://bugs.kde.org/show_bug.cgi?id=181290


Diffs (updated)
-----

  core/document.h 587c03c 
  core/document.cpp 8af1840 
  core/fileprinter.h f17e09d 
  core/fileprinter.cpp f08b104 
  generators/djvu/generator_djvu.cpp f05c0eb 
  generators/dvi/dviRenderer.h 8f5f95a 
  generators/dvi/dviRenderer.cpp b80350a 
  generators/dvi/dviexport.h 295dc6e 
  generators/dvi/dviexport.cpp f866559 
  generators/dvi/generator_dvi.cpp 35a8976 
  generators/poppler/generator_pdf.cpp 42bad00 
  generators/spectre/generator_ghostview.cpp 7150df8 
  part.cpp 5b0346d 

Diff: http://git.reviewboard.kde.org/r/101513/diff


Testing
-------

r2 compiles for Fedora 15: http://koji.fedoraproject.org/koji/buildinfo?buildID=246374 (and Fedora 14 and 13 too)

Runtime test results by Falk: https://bugs.kde.org/show_bug.cgi?id=181290#c99


Thanks,

Kevin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/okular-devel/attachments/20110727/f765132b/attachment.htm