[Okular-devel] [Bug 181290] Landscape pdf prints with wrong orientation when choosing landscape in print dialog

[Pino Toscano]

https://bugs.kde.org/show_bug.cgi?id=181290





--- Comment #107 from Pino Toscano <pino kde org>  2011-07-27 20:44:28 ---
(In reply to comment #106)
> > but at least you should fix the FIXMEs in your code.
> 
> As far as I can tell, the one function with a FIXME in it
> (FilePrinter::printFiles, as opposed to FilePrinter::printFile which is what is
> actually being used) is used nowhere in all of Okular. (I searched the entire
> code for uses of them and didn't find any.) I have no idea why it's there in
> the first place.
> 
> If you think I should just remove that unused function, I can do it.

See below.

> > You are also breaking BC of the okular core library which is something we do
> > not like.
> 
> It is necessary to make those API changes to fix this problem cleanly. It could
> probably be hacked around without adding those extra function arguments, but
> that doesn't strike me as a good long-term solution.

In the long term: when the BC of okular core will be broken, the deprecate
functions will be removed.
So yes, you will add new functions without breaking okular core's ABI, if you
want your patch in.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.