[Okular-devel] Re: About 265002 (Unreachable code in okular/ui/pageview.cpp (related to drag scroll))

[Денис Песоцкий]

revision 1156337 hasn't any bug reference in annotation, what ar you
talking about?

2011/2/2 Albert Astals Cid <aacid at kde.org>:
> A Dimarts, 1 de febrer de 2011, Денис Песоцкий va escriure:
>> Thank you, now it works. Inserted qDebug messages in that ifs about
>> absDelta. They happen only if I scroll very fast (as excepted — mouse
>> moves fast, so delta is high). And, as I said, moving cursor fast
>> leads to wrong scrolling.
>> When I removed that blocks, it works as excepted.
>> When I added my margin, it still works as excepted.
>> There is also same absDelta code in zoom, but it can be removed too,
>> logic there is absolutely same — mousePose is always real last pos.
>> I also tested scrolling with mouse wrapping in 2 directions with same
>> algorithm in my app, it works as excepted too.
>> So that absDelta is noot needed. And it was obvious from code :S.
>
> You are not testing the issue that bug fixes, are you? Put your plasma panel
> on the left and/or at the top and then try again. And check if scrolling with
> mouse wrapping still works.
>
> Albert
>
>>
>> 2011/2/2 Albert Astals Cid <aacid at kde.org>:
>> > A Dimarts, 1 de febrer de 2011, Денис Песоцкий va escriure:
>> >> obey at damnbook okular % pwd
>> >> /home/obey/tmp/kdegraphics/build/okular
>> >> obey at damnbook okular % export KDEDIRS=$(pwd):$(kde4-config --prefix)
>> >> obey at damnbook okular % kbuildsycoca4
>> >> kbuildsycoca4 running...
>> >> obey at damnbook okular % ./shell/okular
>> >> ~/Downloads/Deluge/c_cpp_standards/c_iso_iec_9899_1999.pdf
>> >> And it work like I've not changed anything (y, ofc I recompiled it).
>> >
>> > You have to install it, even if it is in
>> > home/obey/tmp/kdegraphics/install
>> >
>> > You can not run it from the build dir
>> >
>> > Albert
>> >
>> >> 2011/2/2 Albert Astals Cid <aacid at kde.org>:
>> >> > A Dimarts, 1 de febrer de 2011, Денис Песоцкий va escriure:
>> >> >> Yes, I've tried that. I make changes to ui/pageview.cpp, recompile
>> >> >> it, start ./shell/okular and it works like nothing happend. Ever if
>> >> >> I don't create d-pointer in constructor. Probably it loads that lib
>> >> >> dynamically from my system.
>> >> >
>> >> > That's the part when you read the page again and see
>> >> >
>> >> > If you install Okular in a different path than your system kde4
>> >> > install directory it is possible that you need to run
>> >> >
>> >> > export KDEDIRS=/path/to/where/you/installed/okular:$(kde4-config
>> >> > --prefix) kbuildsycoca4
>> >> >
>> >> > so that the correct Okular instance and libraries are picked up
>> >> >
>> >> > Albert
>> >> >
>> >> >> 2011/2/2 Albert Astals Cid <aacid at kde.org>:
>> >> >> > A Dimarts, 1 de febrer de 2011, Денис Песоцкий va escriure:
>> >> >> >> > As said in the other mail, check the svn logs and make sure your
>> >> >> >> > fix does not break what the other code was supposed to fix.
>> >> >> >>
>> >> >> >> Ok, I found that commit:
>> >> >> >> http://websvn.kde.org/?view=revision&revision=1156337 Anyway, I
>> >> >> >> can't understand what for it is needed and did he fixed
>> >> >> >> anything. Because any time it wraps, It saves new mouse position,
>> >> >> >> it is obvious. Please debug that blocks. I can't because I don't
>> >> >> >> know how to build it.
>> >> >> >
>> >> >> > http://okular.kde.org/download.php
>> >> >> >
>> >> >> > Albert
>> >> >> >
>> >> >> >> > Control your language
>> >> >> >>
>> >> >> >> Sorry for that.
>> >> >> >> _______________________________________________
>> >> >> >> Okular-devel mailing list
>> >> >> >> Okular-devel at kde.org
>> >> >> >> https://mail.kde.org/mailman/listinfo/okular-devel
>> >> >> >
>> >> >> > _______________________________________________
>> >> >> > Okular-devel mailing list
>> >> >> > Okular-devel at kde.org
>> >> >> > https://mail.kde.org/mailman/listinfo/okular-devel
>> >> >>
>> >> >> _______________________________________________
>> >> >> Okular-devel mailing list
>> >> >> Okular-devel at kde.org
>> >> >> https://mail.kde.org/mailman/listinfo/okular-devel
>> >> >
>> >> > _______________________________________________
>> >> > Okular-devel mailing list
>> >> > Okular-devel at kde.org
>> >> > https://mail.kde.org/mailman/listinfo/okular-devel
>> >>
>> >> _______________________________________________
>> >> Okular-devel mailing list
>> >> Okular-devel at kde.org
>> >> https://mail.kde.org/mailman/listinfo/okular-devel
>> >
>> > _______________________________________________
>> > Okular-devel mailing list
>> > Okular-devel at kde.org
>> > https://mail.kde.org/mailman/listinfo/okular-devel
>>
>> _______________________________________________
>> Okular-devel mailing list
>> Okular-devel at kde.org
>> https://mail.kde.org/mailman/listinfo/okular-devel
> _______________________________________________
> Okular-devel mailing list
> Okular-devel at kde.org
> https://mail.kde.org/mailman/listinfo/okular-devel
>