[Okular-devel] Review Request: make core/document.cpp compile without warning when QT_ASCII_CAST_WARNINGS is set

[Albert Astals Cid]

> On Aug. 28, 2011, 6:54 p.m., Albert Astals Cid wrote:
> > Personally i do not like this kind of change because i've been already bit by Laurent blindly changing some code in KTuberling to "fix" this and the code stopping to work.
> > 
> > I am not going to make the silly effort to make sure you do not break anything, so you have three options:
> >  * Commit it, and i case you break something take all my love
> >  * Do not commit it and wait for Laurent to do it, so he will take my love instead of me when something breaks
> >  * Live without the 0.0000000000000000000000000001% speed increase
> > 
> > Your choice.

Please can you decide if you want to take the responsability of commiting it and do it and if not close the review request? It's making my reviewboard dashboard "red"-er than it needs to be.

Thanks,
  Albert


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102453/#review6109
-----------------------------------------------------------


On Aug. 27, 2011, 11:57 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102453/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2011, 11:57 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> Or: flood code with QLatin1String/QLatin1Char
> 
> Interested in such patches? Would do more to the other files if you welcome these changes.
> Have not done any measurements if this brings real advantages, but some µ-improvements should be there by theory.
> 
> Style okay? Or should resulting very long lines be broken? And should there be spaces between '('/')' and '"' ?
> 
> 
> Diffs
> -----
> 
>   core/document.cpp a417828 
> 
> Diff: http://git.reviewboard.kde.org/r/102453/diff/diff
> 
> 
> Testing
> -------
> 
> Could still load and navigate a PDF with a toc.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20111228/8a4ee98d/attachment.html>