[Okular-devel] Review Request: Add greedy preloading option

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103129/#review9333
-----------------------------------------------------------


Where did the changes to pageview.cpp go?
Also you are still using tabs in places you should use spaces (see how reviewboard shows the alignment in conf/dlgperformance.cpp is broken)

- Albert Astals Cid


On Dec. 21, 2011, 10:39 a.m., Sebastian Rose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103129/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2011, 10:39 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> After discovering that the aggressive behaviour in okular is not that aggressive at all (preloads only the next 2 pages) I've written the attached patch to add a "Greedy" option. It preloads every page into memory.
> 
> 
> Diffs
> -----
> 
>   conf/dlgperformance.cpp fd0e30b 
>   conf/dlgperformancebase.ui b022f56 
>   conf/okular.kcfg 430af7c 
>   core/document.cpp 74757f1 
>   ui/presentationwidget.cpp 7c3f618 
> 
> Diff: http://git.reviewboard.kde.org/r/103129/diff/diff
> 
> 
> Testing
> -------
> 
> Tested it on my local system, I'm using the modified okular with the new greedy option checked and don't have any issues so far. The memory requirement for a 580 page (color) PDF file is about 1 GiB, the bulk of it for the pixmaps. Other (e.g. unloading) behaviour is like "Aggressive". It takes a while for the whole document to be prerendered but after that it works as expected.
> 
> 
> Thanks,
> 
> Sebastian Rose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20111228/4b98f89c/attachment.html>