[Okular-devel] Review Request: Several variables aren't 'const' in PageView::slotRelayoutPages when they probably should be

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103486/#review9257
-----------------------------------------------------------


This review has been submitted with commit cdc1b0c78dd9ccc3a66cfd550f5b35ed06b3bcba by Stephen Anthony to branch KDE/4.8.

- Commit Hook


On Dec. 21, 2011, 2:32 p.m., Stephen Anthony wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103486/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2011, 2:32 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> The pageCount variable is used as a constant everywhere except one place, where it is incremented by a certain amount and then decremented by that same amount a few lines later.  This patch explicitly makes pageCount const, and takes care of the special case directly in the ternary if.  As a result of making pageCount const, several related variables are also made const.
> 
> 
> Diffs
> -----
> 
>   ui/pageview.cpp e6eb771 
> 
> Diff: http://git.reviewboard.kde.org/r/103486/diff/diff
> 
> 
> Testing
> -------
> 
> Tested with a few documents with differing page lengths in all viewmodes.
> 
> 
> Thanks,
> 
> Stephen Anthony
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20111225/ba0b7455/attachment.html>