[Okular-devel] Review Request: Allow the page number selector to be docked in a toolbar

[Jonathan Marten]

> On Dec. 19, 2011, 7:30 p.m., Albert Astals Cid wrote:
> > I am not sure that atuomatically hiding it from the bottom part means you want to see it in the toolbar.
> > 
> > Also no new features are accepted in released branches so sadly this is 4.9 material.

True, but it can only appear in the toolbar if the bottom bar *is* hidden (because the MiniBar is effectively a singleton).  If the user neither wants it in the toolbar nor the bottom bar, then they can hide the tool or its containing toolbar.


> On Dec. 19, 2011, 7:30 p.m., Albert Astals Cid wrote:
> > part.rc, line 90
> > <http://git.reviewboard.kde.org/r/103427/diff/1/?file=43528#file43528line90>
> >
> >     Can you revert this whitespace change?

OK.


> On Dec. 19, 2011, 7:30 p.m., Albert Astals Cid wrote:
> > ui/pagesizelabel.cpp, line 71
> > <http://git.reviewboard.kde.org/r/103427/diff/1/?file=43529#file43529line71>
> >
> >     This looks unrelated to the feature?

It was needed in an earlier version of this change, when it looked as if it was going to be necessary to delete the bottom bar completely when it was not being shown in order to release the MiniBar.  However, it is not necessary now - will revert.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103427/#review9097
-----------------------------------------------------------


On Dec. 16, 2011, 1:04 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103427/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2011, 1:04 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> The bug (and duplicates) suggests that the page bar which normally appears at the bottom of the Okular window could be docked in the toolbar, in order to save vertical screen space which is especially useful on a wide screen.  This patch implements that.
> 
> There can only be one MiniBar in existence, because of the fixed observer ID (which must be unique).  So the page tool only appears in the toolbar if the page bar is hidden;  if it is shown, then the page number and size label appears there as before.  The MiniBar is reparented in Part::slotShowBottomBar() when the page bar is shown or hidden.
> 
> The page tool is placed in its own toolbar by default, so that it can be positioned or floated in accordance with the user's preference.
> 
> There are GUI changes and a new I18N string, so this change (if accepted) would be targeted at KDE SC 4.8.1 or later.
> 
> 
> This addresses bug 279128.
>     http://bugs.kde.org/show_bug.cgi?id=279128
> 
> 
> Diffs
> -----
> 
>   part-viewermode.rc dbd8e42 
>   part.h cae5af0 
>   part.cpp b3b4234 
>   part.rc 33d3829 
>   ui/pagesizelabel.cpp 4a80779 
> 
> Diff: http://git.reviewboard.kde.org/r/103427/diff/diff
> 
> 
> Testing
> -------
> 
> Built Okular from master with these changes.  Checked operation in both embedded and standalone modes with page bar shown or not, with a variety of PDF files.
> 
> 
> Screenshots
> -----------
> 
> With page bar shown
>   http://git.reviewboard.kde.org/r/103427/s/372/
> With page bar hidden
>   http://git.reviewboard.kde.org/r/103427/s/373/
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20111219/98d89c81/attachment.html>