[Okular-devel] Review Request: Improve facing pages (center first page) mode when document contains only 1 or 2 pages

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103424/#review8988
-----------------------------------------------------------



ui/pageview.cpp
<http://git.reviewboard.kde.org/r/103424/#comment7462>

    I kind of prefer the centerFirstPage and facingPages to be const still, can you put the pageCount<3 comparison in their assignment lines? Or do you think it impairs readability?



ui/pageview.cpp
<http://git.reviewboard.kde.org/r/103424/#comment7461>

    This looks like an unnecessary change for the bugfix right? Please revert if so


- Albert Astals Cid


On Dec. 15, 2011, 10:45 p.m., Stephen Anthony wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103424/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2011, 10:45 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> This patch improves 'facing pages (center first page)' mode in the case where a document consists of only 1 or 2 pages.  Currently, this mode always assumes two columns of output (which makes sense for 'facing pages').  However, in the case of 1 or 2 page documents, the pages are sized according to two columns, when only one column will ever be used (because of the number of pages present), resulting in pages that don't fill the page in 'Fit to Page' view mode.
> 
> Basically, this patch overrides facing pages in such a case and uses one virtual column, allowing the page to take all available space.
> 
> 
> Diffs
> -----
> 
>   ui/pageview.cpp 78a007a 
> 
> Diff: http://git.reviewboard.kde.org/r/103424/diff/diff
> 
> 
> Testing
> -------
> 
> Testing was done on 1, 2, 3, many page documents in all modes and views.  This patch addresses the specific case where 'facing pages (center first page)' is enabled AND the pagecount is 2 or less.
> 
> 
> Thanks,
> 
> Stephen Anthony
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20111215/cdd6f8c1/attachment.html>