[Okular-devel] Review Request: Implement the handling of page rotations for source references

[Michel Ludwig]

> On Dec. 6, 2011, 10:09 p.m., Albert Astals Cid wrote:
> > part.cpp, line 1712
> > <http://git.reviewboard.kde.org/r/103060/diff/4/?file=41937#file41937line1712>
> >
> >     Use rotateNormalisedToRotation0 here?

It depends on what Part::slotGotoLast is supposed to do. I took it as: move the vertical scroll bar as far down as possible, and the horizontal one as far left as possible.

Hence, the required viewport position relative to Rotation0 changes.

But if you see it differently, I can also change it.


> On Dec. 6, 2011, 10:09 p.m., Albert Astals Cid wrote:
> > ui/pageview.cpp, line 1007
> > <http://git.reviewboard.kde.org/r/103060/diff/4/?file=41940#file41940line1007>
> >
> >     I don't like the fact that we need to pass the viewport here, i take that you need to pass it because someone is changing it? What we should do is fix the one that is changing it, not pass it to the function.

Actually, if I remember correctly, it also works fine without storing the viewport. I just thought that it might be safer to store it, but I can change it back if you don't like it.


- Michel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103060/#review8773
-----------------------------------------------------------


On Nov. 24, 2011, 8:36 p.m., Michel Ludwig wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103060/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2011, 8:36 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> Implement the handling of page rotations for source references.
> 
> 
> Diffs
> -----
> 
>   core/document.h 78ce53a 
>   core/document.cpp b3ddb46 
>   core/page.h 46fba72 
>   core/page.cpp bb3dbbd 
>   core/utils.h 8d5d5fc 
>   core/utils.cpp 5dd8448 
>   generators/dvi/generator_dvi.cpp 16d124b 
>   generators/poppler/generator_pdf.cpp d88da80 
>   part.cpp dd4f2b5 
>   ui/pagepainter.cpp ca55e81 
>   ui/pageview.h 63b0af0 
>   ui/pageview.cpp 82f54d1 
>   ui/side_reviews.cpp 40a7adf 
>   ui/thumbnaillist.cpp 60a43c4 
> 
> Diff: http://git.reviewboard.kde.org/r/103060/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michel Ludwig
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20111207/450765da/attachment-0001.html>