[Okular-devel] Review Request: Added configuration setting for default zoom

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102491/#review6183
-----------------------------------------------------------


Thanks for sending the patch but the quality of the patch is unacceptable. If you are going to provide an option you should do it properly, not with a hack.

- Albert


On Aug. 30, 2011, 2:58 p.m., Michal Švec wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102491/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2011, 2:58 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Summary
> -------
> 
> Added configuration setting for default zoom (no UI yet).
> This is a trivial fix for bug 169516.
> 
> It's enough to write this to okularrc:
>   [PageView]
>   InitialZoom=ZoomFitPage
> 
> 
> This addresses bug 169516.
>     http://bugs.kde.org/show_bug.cgi?id=169516
> 
> 
> Diffs
> -----
> 
>   ui/pageview.cpp 871b9e4 
> 
> Diff: http://git.reviewboard.kde.org/r/102491/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20110831/3c7b1015/attachment.html>