[Okular-devel] Review Request: table selection tool - new feature

[Jiri Baum]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102358/
-----------------------------------------------------------

(Updated Aug. 29, 2011, 12:05 p.m.)


Review request for Okular.


Changes
-------

Changes as per the review, except the zoom problem is still TODO.


Summary
-------

Table selection tool, as per the bug description.

Usage: from the menu, select Tools | Table Selection Tool (or use the shortcut Ctrl-5). Use the mouse to select the whole table (in a manner similar to the existing Selection Tool), then click near the edges of the table to add and remove row and column dividers; the table is automatically copied to the clipboard after each change. When ready, paste into another document (spreadsheet, word processor, etc). Press Esc to clear the selection.

The patch also fixes handling of Esc key, so that it's not consumed by the closeFindBar KAction when the FindBar is closed. Previously this bug was non-obvious since the rectangular selection tool can in any case be cancelled by releasing the mouse button, then pressing Esc; cancelling it without releasing the mouse button was presumably not a common use-case.


This addresses bug 279859.
    http://bugs.kde.org/show_bug.cgi?id=279859


Diffs (updated)
-----

  AUTHORS 55b672e 
  aboutdata.h f9c5896 
  part.h a36031b 
  part.cpp e6b80a5 
  part.rc 928168d 
  ui/pageview.h cd88b99 
  ui/pageview.cpp 25da571 

Diff: http://git.reviewboard.kde.org/r/102358/diff


Testing
-------

It works for me, even under demo conditions...


Thanks,

Jiri

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20110829/31282ebf/attachment.html>