[Okular-devel] Review Request: table selection tool - new feature

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102358/#review6127
-----------------------------------------------------------



part.rc
<http://git.reviewboard.kde.org/r/102358/#comment5396>

    Please do not write tbl, use table



ui/pageview.h
<http://git.reviewboard.kde.org/r/102358/#comment5397>

    Same here



ui/pageview.h
<http://git.reviewboard.kde.org/r/102358/#comment5399>

    selectionRect should be const here, and by having a quick look at the function seems the function itself may be const too?
    
    Also please do not pass int b, use a proper enum for that



ui/pageview.h
<http://git.reviewboard.kde.org/r/102358/#comment5398>

    Same here



ui/pageview.cpp
<http://git.reviewboard.kde.org/r/102358/#comment5400>

    no capital as first letter, tbl -> table and probably better if you add "selection" somewhere in the variable name



ui/pageview.cpp
<http://git.reviewboard.kde.org/r/102358/#comment5401>

    tbl->table



ui/pageview.cpp
<http://git.reviewboard.kde.org/r/102358/#comment5403>

    Have not tried, but does this survive zooming in/out of the document?



ui/pageview.cpp
<http://git.reviewboard.kde.org/r/102358/#comment5404>

    Nitpicking (as i know almost none of our code does it) but it would be cool if you added const to the variables you know won't change (like selectionRect), makes it easier to read for the new person reading it 



ui/pageview.cpp
<http://git.reviewboard.kde.org/r/102358/#comment5405>

    You need to use if ( d->document->isAllowed( Okular::AllowCopy ) ) somewhere here



ui/pageview.cpp
<http://git.reviewboard.kde.org/r/102358/#comment5406>

    spacing is a bit odd here, either remove the first space or add one after bb



ui/pageview.cpp
<http://git.reviewboard.kde.org/r/102358/#comment5402>

    No two methods in the same line please


- Albert


On Aug. 18, 2011, 5:34 a.m., Jiri Baum wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102358/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2011, 5:34 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Summary
> -------
> 
> Table selection tool, as per the bug description.
> 
> Usage: from the menu, select Tools | Table Selection Tool (or use the shortcut Ctrl-5). Use the mouse to select the whole table (in a manner similar to the existing Selection Tool), then click near the edges of the table to add and remove row and column dividers; the table is automatically copied to the clipboard after each change. When ready, paste into another document (spreadsheet, word processor, etc). Press Esc to clear the selection.
> 
> The patch also fixes handling of Esc key, so that it's not consumed by the closeFindBar KAction when the FindBar is closed. Previously this bug was non-obvious since the rectangular selection tool can in any case be cancelled by releasing the mouse button, then pressing Esc; cancelling it without releasing the mouse button was presumably not a common use-case.
> 
> 
> This addresses bug 279859.
>     http://bugs.kde.org/show_bug.cgi?id=279859
> 
> 
> Diffs
> -----
> 
>   AUTHORS 55b672e 
>   aboutdata.h f9c5896 
>   part.h a36031b 
>   part.cpp e6b80a5 
>   part.rc 928168d 
>   ui/pageview.h cd88b99 
>   ui/pageview.cpp 25da571 
> 
> Diff: http://git.reviewboard.kde.org/r/102358/diff
> 
> 
> Testing
> -------
> 
> It works for me, even under demo conditions...
> 
> 
> Thanks,
> 
> Jiri
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20110829/87562ec5/attachment-0001.html>